From 7f071e11d3f05c6fbdd64987b2c557e6a8a1f899 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Forment?= <raphael.forment@gmail.com>
Date: Wed, 5 Jun 2024 00:13:21 +0200
Subject: [PATCH] add flanger and phaser, fix some fxs

---
 Classes/BuboNodeProxyEffects.sc | 52 +++++++++++++++++++++++++++------
 1 file changed, 43 insertions(+), 9 deletions(-)

diff --git a/Classes/BuboNodeProxyEffects.sc b/Classes/BuboNodeProxyEffects.sc
index 0c4f2d9..28a55c1 100644
--- a/Classes/BuboNodeProxyEffects.sc
+++ b/Classes/BuboNodeProxyEffects.sc
@@ -50,24 +50,38 @@
       })
     }
 
-
     flanger {
-      /* FIX: Make it better than it currently is */
-      arg modSpeed=0.1, modDepth=0.01, pos=950, wet=1;
+      arg pos=950, wet=1, maxdelay=0.013, maxrate=10.0, delay=0.1, depth=0.08, rate=0.06, fdbk=0.0, decay=0.0;
       this.fx(pos, wet, {
         arg in;
-        var lfo = SinOsc.kr(modSpeed, 3pi / 2).range(0.001, modDepth);
-        var delay = DelayL.ar(in, 0.01, lfo);
-        in + delay
+        var dsig, mixed, local;
+        local = LocalIn.ar(1);
+        dsig = AllpassL.ar(
+          in + (local * fdbk),
+          maxdelay * 2,
+          LFPar.kr(
+            rate * maxrate, 0,
+            depth * maxdelay,
+            delay * maxdelay
+          ), decay
+        );
+        mixed = in + dsig;
+        mixed
       })
     }
 
     phaser {
-      /* TODO: implement */
-      arg pos=950, wet=1;
+      arg pos=950, wet=1, speed=1;
       this.fx(pos, wet, {
         arg in;
-        in
+        var delay = AllpassL.ar(in, 4,
+          SinOsc.kr(speed).range(
+            0.000022675,
+            0.01
+          ) + (0.01).rand,
+          0
+        );
+        delay
       })
     }
 
@@ -177,6 +191,26 @@
       });
     }
 
+    dub {
+      arg in, length = 1, fb = 0.8, sep = 0.012, pos=950, wet=1;
+      this.fx(pos, wet, {
+        arg in;
+	      var output = in + Fb({ |feedback|
+	      	var left, right;
+	      	var magic = LeakDC.ar(feedback * fb + in);
+	      	magic = HPF.ar(magic, 400);
+	      	magic = LPF.ar(magic, 5000);
+	      	magic = magic.tanh;
+	      	#left, right = magic;
+	      	magic = [
+            DelayC.ar(left, 1, LFNoise2.ar(12).range(0,sep)),
+            DelayC.ar(right, 1, LFNoise2.ar(12).range(sep,0))
+          ].reverse;
+	      },length);
+        output
+      });
+    }
+
     lpf {
       arg cutoff=10000, resonance=0.5, pos=950, wet=1;
       this.fx(pos, wet, {