Code quality checks

src/components/LFOScope.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useRef, useState } from 'react'
+import { useEffect, useRef, useState, useCallback } from 'react'
 import { useStore } from '@nanostores/react'
 import { LFO, type LFOWaveform } from '../domain/modulation/LFO'
 import { mappingMode } from '../stores/mappingMode'
@@ -34,6 +34,27 @@ export function LFOScope({ lfoIndex, waveform, frequency, phase, mappings, onCha
   const dragStartRef = useRef<{ x: number; y: number; freq: number; phase: number; moved: boolean } | null>(null)
   const mappingModeState = useStore(mappingMode)
 
+  const getLFOValueAtPhase = useCallback((phaseVal: number): number => {
+    const normalizedPhase = phaseVal % 1
+
+    switch (waveform) {
+      case 'sine':
+        return Math.sin(normalizedPhase * 2 * Math.PI)
+      case 'triangle':
+        return normalizedPhase < 0.5
+          ? -1 + 4 * normalizedPhase
+          : 3 - 4 * normalizedPhase
+      case 'square':
+        return normalizedPhase < 0.5 ? 1 : -1
+      case 'sawtooth':
+        return 2 * normalizedPhase - 1
+      case 'random':
+        return Math.sin(normalizedPhase * 2 * Math.PI)
+      default:
+        return 0
+    }
+  }, [waveform])
+
   useEffect(() => {
     if (!lfoRef.current) {
       lfoRef.current = new LFO(new AudioContext(), frequency, phase, waveform)
@@ -98,28 +119,7 @@ export function LFOScope({ lfoIndex, waveform, frequency, phase, mappings, onCha
         cancelAnimationFrame(animationRef.current)
       }
     }
-  }, [frequency, waveform, phase])
-
-  const getLFOValueAtPhase = (phase: number): number => {
-    const normalizedPhase = phase % 1
-
-    switch (waveform) {
-      case 'sine':
-        return Math.sin(normalizedPhase * 2 * Math.PI)
-      case 'triangle':
-        return normalizedPhase < 0.5
-          ? -1 + 4 * normalizedPhase
-          : 3 - 4 * normalizedPhase
-      case 'square':
-        return normalizedPhase < 0.5 ? 1 : -1
-      case 'sawtooth':
-        return 2 * normalizedPhase - 1
-      case 'random':
-        return Math.sin(normalizedPhase * 2 * Math.PI)
-      default:
-        return 0
-    }
-  }
+  }, [frequency, waveform, phase, getLFOValueAtPhase])
 
   const handleMouseDown = (e: React.MouseEvent<HTMLCanvasElement>) => {
     if (e.button === 2) return