From 22b52456fcd562adc0eea9a0f5680f86c2c4121f Mon Sep 17 00:00:00 2001
From: Raphael Forment <raphael.forment@gmail.com>
Date: Fri, 24 Nov 2023 03:04:24 +0100
Subject: [PATCH] Trying to optimize generics

---
 src/Utils/Generic.ts | 129 +++++++++++++++++++++++--------------------
 1 file changed, 70 insertions(+), 59 deletions(-)

diff --git a/src/Utils/Generic.ts b/src/Utils/Generic.ts
index 69e5da1..db4d040 100644
--- a/src/Utils/Generic.ts
+++ b/src/Utils/Generic.ts
@@ -1,73 +1,84 @@
 /*
  * Transforms object with arrays into array of objects
- * 
+ *
  * @param {Record<string, any>} input - Object with arrays
  * @param {string[]} ignoredKeys - Keys to ignore
  * @returns {Record<string, any>[]} Array of objects
- * 
+ *
  */
-export function objectWithArraysToArrayOfObjects(input: Record<string, any>, arraysToArrays: string[]): Record<string, any>[] {
-    arraysToArrays.forEach((k) => {
-        // Transform single array to array of arrays and keep array of arrays as is
-        if (Array.isArray(input[k]) && !Array.isArray(input[k][0])) {
-            input[k] = [input[k]];
-        }
-    });
-    const keys = Object.keys(input);
-    
-    const maxLength = Math.max(
-      ...keys.map((k) =>
-        Array.isArray(input[k]) ? (input[k] as any[]).length : 1
-      )
-    );
-
-    const output: Record<string, any>[] = [];
-
-    for (let i = 0; i < maxLength; i++) {
-      const event: Record<string, any> = {};
-      for (const k of keys) {
-        if (Array.isArray(input[k])) {
-            event[k] = (input[k] as any[])[i % (input[k] as any[]).length];
-        } else {
-            event[k] = input[k];
-        }
-      }
-      output.push(event);
+export function objectWithArraysToArrayOfObjects(
+  input: Record<string, any>,
+  arraysToArrays: string[]
+): Record<string, any>[] {
+  const inputCopy = { ...input };
+  arraysToArrays.forEach((k) => {
+    if (Array.isArray(inputCopy[k]) && !Array.isArray(inputCopy[k][0])) {
+      inputCopy[k] = [inputCopy[k]];
     }
-    return output;
-  };
+  });
 
-/* 
+  const keysAndLengths = Object.entries(inputCopy).reduce(
+    (acc, [key, value]) => {
+      const length = Array.isArray(value) ? (value as any[]).length : 1;
+      acc.maxLength = Math.max(acc.maxLength, length);
+      acc.keys.push(key);
+      return acc;
+    },
+    { keys: [] as string[], maxLength: 0 }
+  );
+
+  const output: Record<string, any>[] = [];
+  for (let i = 0; i < keysAndLengths.maxLength; i++) {
+    const event: Record<string, any> = {};
+    for (const k of keysAndLengths.keys) {
+      if (Array.isArray(inputCopy[k])) {
+        event[k] = (inputCopy[k] as any[])[i % (inputCopy[k] as any[]).length];
+      } else {
+        event[k] = inputCopy[k];
+      }
+    }
+    output.push(event);
+  }
+  return output;
+}
+
+/*
  * Transforms array of objects into object with arrays
- * 
+ *
  * @param {Record<string, any>[]} array - Array of objects
  * @param {Record<string, any>} mergeObject - Object that is merged to each object in the array
  * @returns {object} Merged object with arrays
- * 
+ *
  */
-export function arrayOfObjectsToObjectWithArrays<T extends Record<string, any>>(array: T[], mergeObject: Record<string, any> = {}): Record<string, any> {
-    return array.reduce((acc, obj) => {
-      Object.keys(mergeObject).forEach((key) => {
-        obj[key as keyof T] = mergeObject[key];
-      });
-      Object.keys(obj).forEach((key) => {
-        if (!acc[key as keyof T]) {
-          acc[key as keyof T] = [];
-        }
-        (acc[key as keyof T] as unknown[]).push(obj[key]);
-      });
-      return acc;
-    }, {} as Record<keyof T, any[]>);
-  }
+export function arrayOfObjectsToObjectWithArrays<T extends Record<string, any>>(
+  array: T[],
+  mergeObject: Record<string, any> = {}
+): Record<string, any> {
+  return array.reduce((acc, obj) => {
+    const mergedObj = { ...obj, ...mergeObject };
+    Object.keys(mergedObj).forEach((key) => {
+      if (!acc[key]) {
+        acc[key] = [];
+      }
+      acc[key].push(mergedObj[key]);
+    });
+    return acc;
+  }, {} as Record<string, any>);
+}
 
-  /* 
-   * Filter certain keys from object
-   *
-   * @param {Record<string, any>} obj - Object to filter
-   * @param {string[]} filter - Keys to filter
-   * @returns {object} Filtered object
-   *
-   */
-  export function filterObject(obj: Record<string, any>, filter: string[]): Record<string, any> {
-    return Object.fromEntries(Object.entries(obj).filter(([key]) => filter.includes(key)));
-  }
\ No newline at end of file
+/*
+ * Filter certain keys from object
+ *
+ * @param {Record<string, any>} obj - Object to filter
+ * @param {string[]} filter - Keys to filter
+ * @returns {object} Filtered object
+ *
+ */
+export function filterObject(
+  obj: Record<string, any>,
+  filter: string[]
+): Record<string, any> {
+  return Object.fromEntries(
+    Object.entries(obj).filter(([key]) => filter.includes(key))
+  );
+}