From 268533a5c6b343771b6119442af53071c1fd9322 Mon Sep 17 00:00:00 2001 From: Raphael Forment Date: Sun, 19 Nov 2023 21:36:46 +0100 Subject: [PATCH] minor optimisations --- src/EditorSetup.ts | 3 --- src/KeyActions.ts | 2 -- src/TransportNode.js | 12 +++++++----- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/EditorSetup.ts b/src/EditorSetup.ts index 7cb5c6b..18c0282 100644 --- a/src/EditorSetup.ts +++ b/src/EditorSetup.ts @@ -100,9 +100,6 @@ export const installEditor = (app: Editor) => { editorSetup, toposTheme, app.chosenLanguage.of(javascript()), - EditorView.updateListener.of((v: ViewUpdate) => { - v; - }), ]; app.dynamicPlugins = new Compartment(); app.state = EditorState.create({ diff --git a/src/KeyActions.ts b/src/KeyActions.ts index 893d403..bec746b 100644 --- a/src/KeyActions.ts +++ b/src/KeyActions.ts @@ -135,10 +135,8 @@ export const registerOnKeyDown = (app: Editor) => { if (event.keyCode === keycode) { event.preventDefault(); if (event.ctrlKey) { - event.preventDefault(); app.api.script(keycode - 111); } else { - event.preventDefault(); app.changeModeFromInterface("local"); app.changeToLocalBuffer(index); hideDocumentation(); diff --git a/src/TransportNode.js b/src/TransportNode.js index 220072f..987df5c 100644 --- a/src/TransportNode.js +++ b/src/TransportNode.js @@ -12,9 +12,9 @@ export class TransportNode extends AudioWorkletNode { /** @type {(this: MessagePort, ev: MessageEvent) => any} */ handleMessage = (message) => { - if(message.data) { + if (message.data) { if (message.data.type === "bang") { - if(this.app.clock.running) { + if (this.app.clock.running) { if (this.app.settings.send_clock) { this.app.api.MidiConnection.sendMidiClock(); } @@ -22,8 +22,10 @@ export class TransportNode extends AudioWorkletNode { this.app.clock.tick ); this.app.clock.time_position = futureTimeStamp; - this.timeviewer.innerHTML = `${zeroPad(futureTimeStamp.bar, 2)}:${futureTimeStamp.beat + 1 - }:${zeroPad(futureTimeStamp.pulse, 2)} / ${this.app.clock.bpm}`; + if (futureTimeStamp.pulse % this.app.clock.ppqn == 0) { + this.timeviewer.innerHTML = `${zeroPad(futureTimeStamp.bar, 2)}:${futureTimeStamp.beat + 1 + } / ${this.app.clock.bpm}`; + } if (this.app.exampleIsPlaying) { tryEvaluate(this.app, this.app.example_buffer); } else { @@ -60,6 +62,6 @@ export class TransportNode extends AudioWorkletNode { } stop() { - this.port.postMessage({type: "stop" }); + this.port.postMessage({ type: "stop" }); } }