From a86d0c923a7de431b9d7271c52e25465e6129b99 Mon Sep 17 00:00:00 2001 From: JulienH2000 Date: Thu, 21 Sep 2023 19:41:28 +0200 Subject: [PATCH] corrected useless shift/push/return / delete ambiguous import in API.ts + scale = scale; --- src/API.ts | 3 --- src/ArrayExtensions.ts | 7 ++++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/API.ts b/src/API.ts index ee919a0..012e7ec 100644 --- a/src/API.ts +++ b/src/API.ts @@ -2,12 +2,10 @@ import { seededRandom } from "zifferjs"; import { MidiConnection } from "./IO/MidiConnection"; import { tryEvaluate, evaluateOnce } from "./Evaluator"; import { DrunkWalk } from "./Utils/Drunk"; -import { scale } from "./Scales"; import { Editor } from "./main"; import { SoundEvent } from "./classes/SoundEvent"; import { MidiEvent } from "./classes/MidiEvent"; import { LRUCache } from "lru-cache"; -import { SCALES } from "./Scales" import { InputOptions, Player } from "./classes/ZPlayer"; import { samples, @@ -1514,7 +1512,6 @@ export class UserAPI { this._logMessage(message); }; - scale = scale; rate = (rate: number): void => { rate = rate; diff --git a/src/ArrayExtensions.ts b/src/ArrayExtensions.ts index 894a19f..acfe23f 100644 --- a/src/ArrayExtensions.ts +++ b/src/ArrayExtensions.ts @@ -348,6 +348,7 @@ Array.prototype.scale = function (this: T[], scaleName: string = "major") { const scale = SCALES[scaleName]; + //input protect from unknow scale if (!scale) { throw new Error(`Unknown scale ${scaleName}`); } @@ -363,7 +364,7 @@ Array.prototype.scale = function (this: T[], scaleName: string = "major") { } } - this.shift() - this.push(...result); - return this; + //this.shift() + //this = [...result]; + return result; };