From aaffacb265e68098907e242aefe40a0100ee9256 Mon Sep 17 00:00:00 2001
From: Raphael Forment <raphael.forment@gmail.com>
Date: Sun, 22 Oct 2023 23:38:57 +0200
Subject: [PATCH] tweaking defaults

---
 src/API.ts                | 6 +++++-
 src/AudioVisualisation.ts | 2 +-
 src/main.ts               | 6 +++---
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/API.ts b/src/API.ts
index 92cff71..74521f4 100644
--- a/src/API.ts
+++ b/src/API.ts
@@ -26,7 +26,11 @@ import {
 } from "superdough";
 import { Speaker } from "./StringExtensions";
 import { getScaleNotes } from "zifferjs";
-import { OscilloscopeConfig, blinkScript } from "./AudioVisualisation";
+import {
+  OscilloscopeConfig,
+  blinkScript,
+  runOscilloscope,
+} from "./AudioVisualisation";
 
 interface ControlChange {
   channel: number;
diff --git a/src/AudioVisualisation.ts b/src/AudioVisualisation.ts
index 3bef205..64c3145 100644
--- a/src/AudioVisualisation.ts
+++ b/src/AudioVisualisation.ts
@@ -141,6 +141,7 @@ export const runOscilloscope = (
   const HEIGHT = canvas.height;
 
   function draw() {
+    requestAnimationFrame(draw);
     if (!app.osc.enabled) {
       canvasCtx.clearRect(0, 0, WIDTH, HEIGHT);
       return;
@@ -152,7 +153,6 @@ export const runOscilloscope = (
       dataArray = new Float32Array(analyzer.frequencyBinCount);
     }
 
-    requestAnimationFrame(draw);
     analyzer.getFloatTimeDomainData(dataArray);
 
     canvasCtx.fillStyle = "rgba(0, 0, 0, 0)";
diff --git a/src/main.ts b/src/main.ts
index 7d796be..471b9c0 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -62,10 +62,10 @@ export class Editor {
   osc: OscilloscopeConfig = {
     enabled: true,
     color: "#fdba74",
-    thickness: 2,
-    fftSize: 2048,
+    thickness: 4,
+    fftSize: 256,
     orientation: "horizontal",
-    is3D: true,
+    is3D: false,
     size: 1,
   };